From 2887531b19c8add78c31afe1976e7fffccf716c0 Mon Sep 17 00:00:00 2001
From: jake <jake.young.dev@gmail.com>
Date: Fri, 3 Apr 2026 15:52:18 -0400
Subject: [PATCH] improving bash

- i shouldve read thru it
---
 src/install.sh  |  4 ++--
 src/security.sh |  8 ++++----
 src/test.sh     | 10 +++++-----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/install.sh b/src/install.sh
index 5c99db3..ec9632e 100755
--- a/src/install.sh
+++ b/src/install.sh
@@ -3,7 +3,7 @@
 set -eo pipefail
 
 version=$(go version);
-if [ -z "$version" ]; then
+if [[ ! -n "$version" ]]; then
     echo "[FATAL] golang is not installed";
     exit 1;
 fi
@@ -13,6 +13,6 @@ echo "[DEBUG] $version found in install.sh";
 go install golang.org/x/vuln/cmd/govulncheck@latest
 go install github.com/securego/gosec/v2/cmd/gosec@latest
 
-if [ "$TEST_LIBRARY" == "ginkgo" ]; then
+if [[ "$TEST_LIBRARY" == "ginkgo" ]]; then
     go install github.com/onsi/ginkgo/v2/ginkgo@$TEST_VERSION
 fi
\ No newline at end of file
diff --git a/src/security.sh b/src/security.sh
index ae77986..c627b93 100755
--- a/src/security.sh
+++ b/src/security.sh
@@ -2,7 +2,7 @@
 
 set -eo pipefail
 
-if [ "$STATIC_FLAG" == "no" && "$VULN_CHECK" == "no" ]; then
+if [[ "$STATIC_FLAG" == "no" && "$VULN_CHECK" == "no" ]]; then
     echo "[INFO] no security flags set, skipping!";
     exit 0;
 fi
@@ -13,16 +13,16 @@ echo "[DEBUG] $toolchain found in go.mod";
 version=$(go env -json | jq -r ".GOVERSION");
 echo "[DEBUG] $version found in go env";
 
-if [ ! -z "$toolchain" ]; then
+if [[ -n "$toolchain" ]]; then
     echo "[DEBUG] overwriting version with toolchain";
     version=$toolchain;
 fi
 
-if [ "$STATIC_FLAG" == "yes" ]; then
+if [[ "$STATIC_FLAG" == "yes" ]]; then
     if GOTOOLCHAIN=$version gosec ./...; then
         echo "[INFO] gosec passed!";
     else
-        if [ "$STATIC_FAIL" == "yes" ]; then
+        if [[ "$STATIC_FAIL" == "yes" ]]; then
             echo "[FATAL] gosec failed!";
             exit 1;
         else
diff --git a/src/test.sh b/src/test.sh
index 719318b..29e6a8c 100755
--- a/src/test.sh
+++ b/src/test.sh
@@ -2,18 +2,18 @@
 
 set -eo pipefail
 
-if [ "$TEST_LIBRARY" == "none" ]; then
+if [[ "$TEST_LIBRARY" == "none" ]]; then
     echo "[INFO] test-library input not set, skipping unit tests.";
     exit 0;
 fi
 
 echo "[INFO] running unit tests";
-if [ "$TEST_LIBRARY" == "standard" ]; then
+if [[ "$TEST_LIBRARY" == "standard" ]]; then
     if go test ./...; then
         echo "[INFO] unit tests passed!";
         exit 0;
     else
-        if [ "$TEST_FAIL" == "yes" ]; then
+        if [[ "$TEST_FAIL" == "yes" ]]; then
             echo "[FATAL] unit tests failed!";
             exit 1;
         else
@@ -22,12 +22,12 @@ if [ "$TEST_LIBRARY" == "standard" ]; then
     fi
 fi
 
-if [ "$TEST_LIBRARY" == "ginkgo" ]; then
+if [[ "$TEST_LIBRARY" == "ginkgo" ]]; then
     if ginkgo ./...; then
         echo "[INFO] unit tests passed!";
         exit 0;
     else
-        if [ "$TEST_FAIL" == "yes" ]; then
+        if [[ "$TEST_FAIL" == "yes" ]]; then
             echo "[FATAL] unit tests failed!";
             exit 1;
         else