null pointer fix

- need to nil check before pulling value

cmd/command/add.go

@@ -41,10 +41,12 @@ var addCmd = &cobra.Command{
 		cobra.CheckErr(err)
 
 		err = db.SaveCmd(cfgname, cfgcmd)
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		fmt.Println("Command saved")

cmd/command/command.go

@@ -8,6 +8,8 @@ import (
 )
 
 const (
+	//sqlite doesn't have an error type for this error, but we want to catch when this error is thrown
+	//and provide the proper response. It should not be treated as an error if the db isn't setup.
 	ErrInit    = "sqlite3: SQL logic error: no such table: commands"
 	ErrInitRsp = "The 'init' command must be run before mctl can be used"
 )

cmd/command/delete.go

@@ -22,10 +22,12 @@ var deleteCmd = &cobra.Command{
 		defer db.Close()
 
 		err = db.DeleteCmd(args[0])
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		fmt.Println("Command deleted")

cmd/command/run.go

@@ -33,11 +33,11 @@ var runCmd = &cobra.Command{
 		defer db.Close()
 
 		crun, err := db.GetCmd(cname)
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return nil
 			}
-		if err != nil {
 			return err
 		}
 

cmd/command/view.go

@@ -21,10 +21,12 @@ var viewCmd = &cobra.Command{
 		defer db.Close()
 
 		ts, err := db.GetAllCmds()
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		for _, s := range ts {

cmd/destroy.go

@@ -31,10 +31,12 @@ var destroyCmd = &cobra.Command{
 				defer db.Close()
 
 				err = db.Destroy()
+				if err != nil {
 					if err.Error() == command.ErrInit {
 						fmt.Println(command.ErrInitRsp)
 						return
 					}
+				}
 				cobra.CheckErr(err)
 
 				fmt.Println("Configuration is cleared, the 'init' command must be run again.")

cmd/server/active.go

@@ -22,10 +22,12 @@ var activeCmd = &cobra.Command{
 		defer db.Close()
 
 		err = db.SetActiveServer(args[0])
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		fmt.Println("Active server updated")

cmd/server/add.go

@@ -63,10 +63,12 @@ var addCmd = &cobra.Command{
 			Port:     fp,
 			Password: base64.StdEncoding.EncodeToString(ps),
 		})
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		fmt.Println("Server saved")

cmd/server/delete.go

@@ -22,10 +22,12 @@ var deleteCmd = &cobra.Command{
 		defer db.Close()
 
 		err = db.DeleteServer(args[0])
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		fmt.Println("Server deleted")

cmd/server/server.go

@@ -8,6 +8,8 @@ import (
 )
 
 const (
+	//sqlite doesn't have an error type for this error, but we want to catch when this error is thrown
+	//and provide the proper response. It should not be treated as an error if the db isn't setup.
 	ErrInit    = "sqlite3: SQL logic error: no such table: servers"
 	ErrInitRsp = "The 'init' command must be run before mctl can be used"
 )

cmd/server/update.go

@@ -30,10 +30,12 @@ var updateCmd = &cobra.Command{
 		defer db.Close()
 
 		err = db.UpdateServer(args[0], base64.StdEncoding.EncodeToString(ps))
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		fmt.Printf("%s password updated!", args[0])

cmd/server/view.go

@@ -21,10 +21,12 @@ var viewCmd = &cobra.Command{
 		defer db.Close()
 
 		ts, err := db.GetAllServers()
+		if err != nil {
 			if err.Error() == ErrInit {
 				fmt.Println(ErrInitRsp)
 				return
 			}
+		}
 		cobra.CheckErr(err)
 
 		for _, s := range ts {